Jump to conversation
Unresolved conversations (2)
@mangalaman93 mangalaman93 Aug 19, 2024
why is this in a block?
types/conversion.go
@golangcibot golangcibot Sep 20, 2019
line is 118 characters (from `lll`)
Outdated
query/aggregator.go
Resolved conversations (13)
@mangalaman93 mangalaman93 Feb 9, 2023
this doesn't seem like a good idea.
query/aggregator.go
@mangalaman93 mangalaman93 Feb 9, 2023
I think we should return explicit errors when an operation is not supported
query/aggregator.go
@golangcibot golangcibot Sep 17, 2019
File is not `gofmt`-ed with `-s` (from `gofmt`) ```suggestion types.BigFloatID: "big:bigfloat", ```
Outdated
worker/export.go
@golangcibot golangcibot Sep 17, 2019
line is 108 characters (from `lll`)
Outdated
worker/export.go
@ashish-goswami ashish-goswami Sep 17, 2019
correct import.
Outdated
tok/tok.go
@ashish-goswami ashish-goswami Sep 17, 2019
correct import
Outdated
types/scalar_types.go
@ashish-goswami ashish-goswami Sep 17, 2019
run go import
Outdated
types/conversion.go
@ashish-goswami ashish-goswami Sep 17, 2019
same
Outdated
types/conversion.go
@ashish-goswami ashish-goswami Sep 17, 2019
same
Outdated
types/conversion.go
@ashish-goswami ashish-goswami Sep 17, 2019
change name `val` to something else, as val is a type
Outdated
types/conversion.go
@pullrequest pullrequest[bot] Sep 13, 2019
Another case of precision being a magic number. If this changes in one place it should be done in all.
Outdated
types/scalar_types.go
@pullrequest pullrequest[bot] Sep 13, 2019
Have your editor align with the other values or please do so manually.
Outdated
tok/tok.go
@pullrequest pullrequest[bot] Sep 13, 2019
Can the precision value (200) be saved as a constant? It is used in multiple places and if in the future this becomes configurable it will be easier to maintain as a single sentinel or injected value that all callsites read from.
Outdated
types/conversion.go