Vendor latest badger #4007
Vendor latest badger #4007
Conversation
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ A review job has been created and sent to the PullRequest network.
@jarifibrahim you can click here to see the review status or cancel the code review job.
| read += n | ||
| r.startIdx += n | ||
|
|
||
| // Instead of len(cp.buf), we comparing with cap(cp.buf). This ensures that we move to next |
There was a problem hiding this comment.
// Instead of len(cp.buf), we compare with cap(cp.buf)
| // Truncate truncates PageBuffer to length n. | ||
| func (b *PageBuffer) Truncate(n int) { | ||
| pageIdx, startIdx := b.pageForOffset(n) | ||
| // For simplicity of the code reject extra pages. These pages can be kept. |
There was a problem hiding this comment.
Did you mean something like this?
// For simplicity, reject extra pages. The existing pages can be kept
| } | ||
|
|
||
| // PageBuffer consists of many pages. A page is a wrapper over []byte. PageBuffer can act as a | ||
| // replacement of bytes.Buffer. Instead of having single underlying buffer, it has multiple |
There was a problem hiding this comment.
// Instead of having single underlying buffer to Instead of having a single underlying buffer
|
|
||
| // NewPageBuffer returns a new PageBuffer with first page having size pageSize. | ||
| func NewPageBuffer(pageSize int) *PageBuffer { | ||
| b := &PageBuffer{} |
There was a problem hiding this comment.
I understand what is happening here but it is really two steps the way it was written. You are mixing value and pointer semantics together.
Given how you are using the b variable, prefer
b := new(PageBuffer)
| continue | ||
| } | ||
|
|
||
| // When last page in not full to its capacity and we have read all data up to its |
There was a problem hiding this comment.
// When the last page is not ...
There was a problem hiding this comment.
Address the comments from @_pullrequestbot in a separate PR on badger @jarifibrahim
There was a problem hiding this comment.
Great to see the Windows build issue is fixed.
Reviewable status: 0 of 17 files reviewed, 5 unresolved discussions (waiting on @jarifibrahim and @manishrjain)
This change pulls the following commits from badger
http://github.com/dgraph-io/badger/commit/cbdef65 Fix windows build for badger
http://github.com/dgraph-io/badger/commit/ee70ff2 Store entire L0 in memory
http://github.com/dgraph-io/badger/commit/86a77bb Implement PageBuffer
http://github.com/dgraph-io/badger/commit/f88aa0c Add FAQ about manifest version mismatch
http://github.com/dgraph-io/badger/commits/a1ff348 Minor optimizations
http://github.com/dgraph-io/badger/commits/7e99a81 fix small typo ("duing" to "during")
This change is