Skip to content

release/v1.0: Add support for first and offset directive in has function. #4264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

release/v1.0: Add support for first and offset directive in has function. #4264

wants to merge 2 commits into from

Conversation

danielmai
Copy link
Contributor

@danielmai danielmai commented Nov 11, 2019 •
edited by manishrjain
Loading

Cherry-pick of #3970.

  • Cherry-pick only changes related to first and offset optimizations for has() function.
  • Regenerate protos.
  • Fix query tests to match query package test data set of release/v1.0.

This change is Reviewable

balaji and others added 2 commits November 11, 2019 10:23
@danielmai
Add support for first and offset directive in has function. (#3970)
b8009bb 
Fixes #3964

(cherry picked from commit 0f9b5ba)
@danielmai
Fix has function tests.
14f1d39 
The query package data set is different in master and release/v1.0.
MichelDiz
MichelDiz approved these changes Jan 25, 2020
View reviewed changes
Copy link
Contributor

@MichelDiz MichelDiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 5 files at r1, 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@danielmai
Copy link
Contributor Author

Dropping this old PR since v1.0 is no longer supported.

@danielmai danielmai closed this Feb 12, 2021
@danielmai danielmai deleted the danielmai/v1.0-has-function-pagination branch February 12, 2021 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichelDiz MichelDiz MichelDiz approved these changes

@poonai poonai poonai approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielmai @MichelDiz @poonai