Skip to content

docs: Update instructions to build Dgraph from source. #4300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2019

Conversation

danielmai
Copy link
Contributor

@danielmai danielmai commented Nov 21, 2019

Fixes #4272.

These instructions are updated for the build process with Go modules.
Dgraph's own dependencies are not fetched when using go get, so
cloning the repository and running make install (go build / go install)
within the source directory works the expected way.

  • Use make.
  • Update Ratel build instructions, referring to github.com/dgraph-io/ratel.

This change is Reviewable

These instructions are updated for the build process with Go modules.
Dgraph's own dependencies are not fetched when using `go get`, so
cloning the repository and running make install (go build / go install)
within the source directory works the expected way.

* Use make install.
* Ratel build instructions are available from github.com/dgraph-io/ratel.
@danielmai danielmai requested a review from a team November 21, 2019 00:12
Copy link
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @manishrjain and @MichaelJCompton)

Copy link
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @manishrjain and @MichaelJCompton)

Copy link
Contributor

@MichelDiz MichelDiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @manishrjain and @MichaelJCompton)

@danielmai danielmai merged commit c3c1a48 into master Nov 26, 2019
@danielmai danielmai deleted the danielmai/docs-build-from-source branch November 26, 2019 02:24
danielmai added a commit that referenced this pull request Dec 3, 2019
These instructions are updated for the build process with Go modules.
Dgraph's own dependencies are not fetched when using `go get`, so
cloning the repository and running make install (go build / go install)
within the source directory works the expected way.

* Use make install.
* Ratel build instructions are available from github.com/dgraph-io/ratel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Not able to go get Dgraph repo in Darwin
3 participants