Skip to content

Add types in all examples in docs. #4382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Add types in all examples in docs. #4382

merged 1 commit into from
Dec 17, 2019

Conversation

MichelDiz
Copy link
Contributor

@MichelDiz MichelDiz commented Dec 8, 2019

Sometimes users get confused by Dgraph's new behavior related to Types. And I often notice that the cause of this is other examples in the documentation that aren't exemplifying with types. So I had to add them to avoid future confusion like that.


This change is Reviewable

Copy link
Contributor

@martinmr martinmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: but let Daniel or Micheal have a final look.

Reviewed 4 of 4 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @danielmai and @MichaelJCompton)

@MichelDiz MichelDiz merged commit e4229e6 into master Dec 17, 2019
@MichelDiz MichelDiz deleted the MichelDiz/AddType branch December 17, 2019 03:35
danielmai pushed a commit that referenced this pull request Jan 12, 2020
Sometimes users get confused by Dgraph's new behavior related to Types. And I often notice that the cause of this is other examples in the documentation that aren't exemplifying with types. So I had to add them to avoid future confusion like that.

(cherry picked from commit e4229e6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants