Skip to content

graphql: Changed password to secret directive #4852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 28, 2020

Conversation

harshil-goel
Copy link
Contributor

@harshil-goel harshil-goel commented Feb 26, 2020

This change is Reviewable

@harshil-goel harshil-goel added the area/graphql Issues related to GraphQL support on Dgraph. label Feb 26, 2020
@harshil-goel harshil-goel requested a review from a team February 26, 2020 11:07
Copy link
Contributor

@pawanrawal pawanrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: simple and sweet change

Reviewed 3 of 3 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @manishrjain and @MichaelJCompton)

@harshil-goel harshil-goel merged commit 15d32f7 into master Feb 28, 2020
@harshil-goel harshil-goel deleted the harshil-goel/password-acl branch February 28, 2020 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/graphql Issues related to GraphQL support on Dgraph.
Development

Successfully merging this pull request may close these issues.

2 participants