[BREAKING] feat(Enterprise): GraphQL schema get/update, Dgraph schema query/alter and /login are now admin operations #5786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/enterprise
…p-whitelisting # Conflicts: # graphql/admin/admin.go
abhimanyusinghgaur
requested review from
manishrjain,
MichaelJCompton,
pawanrawal and
vvbalaji-dgraph
as code owners
abhimanyusinghgaur
changed the title
pawanrawal
approved these changes
Jul 3, 2020
There was a problem hiding this comment.
On second thoughts, schema{} query should not have IP whitelisting. Otherwise play.dgraph.io aslo won't be able to work. Users should be able to see dgraphs schema but not update it if their IP is not whitelisted.
We'll need to check that docs and getGQLSchema/updateGQLSchema operations at graphql.dgraph.io work after this change.
Reviewed 16 of 16 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @manishrjain, @MichaelJCompton, and @vvbalaji-dgraph)
There was a problem hiding this comment.
Removed IP whitelisting and Poorman's auth for schema query.
Reviewable status: 15 of 16 files reviewed, all discussions resolved (waiting on @manishrjain, @MichaelJCompton, @pawanrawal, and @vvbalaji-dgraph)
abhimanyusinghgaur
added a commit
that referenced
this pull request
Jul 6, 2020
…r and /login are now admin operations (#5786) Fixes #GRAPHQL-494. Please refer this discuss post: https://discuss.dgraph.io/t/authentication-for-admin-endpoints/6786 (cherry picked from commit 30fb625) # Conflicts: # dgraph/cmd/alpha/mutations_mode/docker-compose.yml # systest/bgindex/docker-compose.yml
abhimanyusinghgaur
added a commit
that referenced
this pull request
Jul 8, 2020
…r and /login are now admin operations (#5786) (#5833) * feat(Enterprise): GraphQL schema get/update, Dgraph schema query/alter and /login are now admin operations (#5786) Fixes #GRAPHQL-494. Please refer this discuss post: https://discuss.dgraph.io/t/authentication-for-admin-endpoints/6786 (cherry picked from commit 30fb625) # Conflicts: # dgraph/cmd/alpha/mutations_mode/docker-compose.yml # systest/bgindex/docker-compose.yml
arijitAD
pushed a commit
that referenced
this pull request
Jul 14, 2020
…r and /login are now admin operations (#5786) Fixes #GRAPHQL-494. Please refer this discuss post: https://discuss.dgraph.io/t/authentication-for-admin-endpoints/6786
abhimanyusinghgaur
added a commit
to dgraph-io/tutorial
that referenced
this pull request
Jul 16, 2020
`/alter` now has IP whitelisting with this PR: hypermodeinc/dgraph#5786. So, need to update tour for the same.
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 18, 2020
…r and /login are now admin operations (hypermodeinc#5786) Fixes #GRAPHQL-494. Please refer this discuss post: https://discuss.dgraph.io/t/authentication-for-admin-endpoints/6786
danielmai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #GRAPHQL-494.
Please refer this discuss post: https://discuss.dgraph.io/t/authentication-for-admin-endpoints/6786
Breaking change: Whitelist IPs set via the
--whitelistflag now apply to schema Alter commands.This change is
Docs Preview: