test: Deal with incomplete tests in Jepsen tool #5804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/integrations
martinmr
changed the title
parasssh
approved these changes
Jul 6, 2020
| // Retry incomplete tests. Sometimes tests fail due to temporary errors. | ||
| tries++ | ||
| if tries == maxRetries { | ||
| defer os.Exit(1) |
There was a problem hiding this comment.
maybe a log here before exiting.
martinmr
commented
Jul 6, 2020
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @manishrjain, @parasssh, and @vvbalaji-dgraph)
contrib/jepsen/main.go, line 480 at r1 (raw file):
Previously, parasssh wrote…
maybe a log here before exiting.
Done.
arijitAD
pushed a commit
that referenced
this pull request
Jul 14, 2020
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does two things:
--refresh-clusterto down and up the test cluster before each test. I noticedthat most errors that lead to incomplete tests go away if this is done.
the test. The tool now only returns an exit code of 1 if there's a test failure or a test was incomplete
even after retries.
Related to DGRAPH-971
This change is
Docs Preview: