fix(Dgraph): Queue keys for rollup during mutation. #6145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, keys are only added for rollups during queries. Keys that only receive queries will not be rolled up until they are queried, which can cause issues and slowness. Fixes DGRAPH-2202
martinmr
changed the title
jarifibrahim
approved these changes
Aug 7, 2020
parasssh
approved these changes
Aug 7, 2020
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @manishrjain)
|
I verified with the live loader and I see rollups happening. |
martinmr
added a commit
that referenced
this pull request
Aug 7, 2020
Right now, keys are only added for rollups during queries. Keys that only receive queries will not be rolled up until they are queried, which can cause issues and slowness. Fixes DGRAPH-2202 (cherry picked from commit 3ea5efe)
martinmr
added a commit
that referenced
this pull request
Aug 7, 2020
Right now, keys are only added for rollups during queries. Keys that only receive queries will not be rolled up until they are queried, which can cause issues and slowness. Fixes DGRAPH-2202 (cherry picked from commit 3ea5efe)
|
When we do the mutations, we keep changes in memory and don't write to data to Badger. We write the data when we do the commit. The rollups should be triggered during the commit, not during the mutation. So, this change is wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, keys are only added for rollups during queries. Keys that
only receive queries will not be rolled up until they are queried, which
can cause issues and slowness.
Fixes DGRAPH-2202
This change is