feat(GraphQL): add has filter support #6258
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add HadFilter In the Schema * fix deepsource failure * fix Teamcity failure * fix TestCases * address Pawan's comments * address Pawan's Comments
* add has filter in query_rewriter and add test case * remove space * change Predicate Format and add test cases * minor changes * remove spaces * change in testcases * address Pawan's comments * add more test cases * fix CI failure * add more test cases
* add test data * add e2e tests * remove spacing * change format of has query * change addPost mutation
minhaj-shakeel
requested review from
MichaelJCompton and
pawanrawal
as code owners
pawanrawal
approved these changes
Aug 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GRAPHQL-285
This PR extends GraphQL by adding the capability to query using
hasfilter.haswas previously available in DQL (GraphQL+-), and from now on will also be part of GraphQL.hasfilters out results for a field which havenullvalue.For eg: for the given type:
The given query:
filters return us only those students who have some
nonNullvalue for the fieldname.This change is
Docs Preview: