fix(Dgraph): fix bug when deleting and adding to a single UID predicate in the same transaction. #6431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinmr
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
parasssh
approved these changes
Sep 14, 2020
danielmai
pushed a commit
that referenced
this pull request
Oct 16, 2020
…te in the same transaction. (#6431) The iterate method does not account for delete postings in the same transaction so they have to be preserved manually. Otherwise, if a deletion and an add operation to the same uid happen in the same predicate, the deletion operation is not applied. Fixes DGRAPH-1309 (cherry picked from commit 56c8f3c)
parasssh
pushed a commit
that referenced
this pull request
Oct 16, 2020
…te in the same transaction. (#6431) (#6746) The iterate method does not account for delete postings in the same transaction so they have to be preserved manually. Otherwise, if a deletion and an add operation to the same uid happen in the same predicate, the deletion operation is not applied. Fixes DGRAPH-1309 (cherry picked from commit 56c8f3c) Co-authored-by: Martin Martinez Rivera <martinmr@dgraph.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the iterate method does not account for delete postings in the same transaction
so they have to be preserved manually. Otherwise, if a deletion and an add operation
to the same uid happen in the same predicate, the deletion operation is not
applied.
Fixes DGRAPH-1309
This change is