Initialize posting list in moveToNextPart #6560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `deleteBelowTs` is not zero `it.uidPosting` won't be intialized in `pitr.inti(). This could cause panic when we are doing `pitr.posting()`. Our assumption was that `piter.valdi()` would return false in such cases. This assumption might not always be true. If `it.uids` is empty, we try to move to next valid part of the list. In the function `moveToNextPart` we are intitializing many components of pIterator but not `uidPosting`. If `it.uids` is filled here, `piter.valid()` would become true and we would end up into a panic at `pitr.posting()`
martinmr
approved these changes
Sep 23, 2020
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @manishrjain and @martinmr)
parasssh
approved these changes
Sep 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
deleteBelowTsis not zeroit.uidPostingwon't be intialized inpitr.init(). This could cause panic when we are doingpitr.posting(). Our assumption was thatpiter.valid()would return false in such cases. This assumption might not always be true. Ifit.uidsis empty, we try to move to next valid part of the list. In the functionmoveToNextPartwe are intitializing many components of pIterator but notuidPosting. Ifit.uidsis filled here,piter.valid()would become true and wewould end up into a panic at
pitr.posting().This change is