Skip to content

fix(GraphQL): fix dangling containers in Custom Cluster tests related to GraphQL #6595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

minhaj-shakeel
Copy link
Contributor

@minhaj-shakeel minhaj-shakeel commented Sep 29, 2020

Running ./test.sh -C graphql in the dgraph repository leaves dgraph_mock_1 container dangling. This PR fixes that.
Related to GRAPHQL-560.


This change is Reviewable

@github-actions github-actions bot added the area/graphql Issues related to GraphQL support on Dgraph. label Sep 29, 2020
Copy link
Contributor

@abhimanyusinghgaur abhimanyusinghgaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @abhimanyusinghgaur, @MichaelJCompton, and @pawanrawal)

@minhaj-shakeel minhaj-shakeel changed the title fix(GraphQL): fix dangling containers in Custom Cluster tests fix(GraphQL): fix dangling containers in Custom Cluster tests related to GraphQL Sep 30, 2020
@minhaj-shakeel minhaj-shakeel merged commit a846471 into master Sep 30, 2020
@minhaj-shakeel minhaj-shakeel deleted the minhaj/fix-dangling-containers branch September 30, 2020 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/graphql Issues related to GraphQL support on Dgraph.
Development

Successfully merging this pull request may close these issues.

2 participants