Skip to content

Docs (Authentication):Fix for DGRAPH-2235 to restore missing admin authentication docs deleted by split-pages Docs PR #6709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 14, 2020

Conversation

aaroncarey
Copy link
Contributor

@aaroncarey aaroncarey commented Oct 12, 2020

Fixes DGRAPH-2235


This change is Reviewable

Docs Preview: Dgraph Preview

* https://dgraph.io/docs/deploy/dgraph-administration/ now has missing content from PR 5842 (wiki/content/deploy/index.md)

* https://dgraph.io/docs/query-language/schema/ now has missing content from PR 5842 (wiki/content/query-language/index.md)
@CLAassistant
Copy link

CLAassistant commented Oct 12, 2020

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the area/documentation Documentation related issues. label Oct 12, 2020
@aaroncarey aaroncarey requested a review from pawanrawal October 12, 2020 21:02
Minor wording and typographical updates
@aaroncarey aaroncarey self-assigned this Oct 12, 2020
Copy link
Contributor

@bucanero bucanero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a format suggestion

Copy link

@codelingo codelingo bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 32 rules errored during the review.

Copy link

@codelingo codelingo bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 32 rules errored during the review.

Co-authored-by: Damián Parrino <bucanero@users.noreply.github.com>
Copy link
Contributor

@bucanero bucanero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 2 files at r1, 1 of 1 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aaroncarey, @danielmai, @MichaelJCompton, and @pawanrawal)

Copy link
Contributor Author

@aaroncarey aaroncarey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @bucanero, @danielmai, @MichaelJCompton, and @pawanrawal)


wiki/content/deploy/dgraph-administration.md, line 34 at r2 (raw file):

Previously, bucanero (Damián Parrino) wrote…

Just for consistency, I'd suggest using code formatting for the endpoint list too:

* `/admin`
* `/admin/backup`
* `/admin/config/lru_mb`
* `/admin/draining`
* `/admin/export`
* `/admin/shutdown`
* `/admin/schema`
* `/alter`
* `/login`

Done, thanks for the suggestion!

@aaroncarey aaroncarey merged commit 49ebecd into master Oct 14, 2020
@aaroncarey aaroncarey deleted the admin-endpoint-auth branch October 14, 2020 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Documentation related issues.
Development

Successfully merging this pull request may close these issues.

3 participants