-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Docs (Authentication):Fix for DGRAPH-2235 to restore missing admin authentication docs deleted by split-pages Docs PR #6709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* https://dgraph.io/docs/deploy/dgraph-administration/ now has missing content from PR 5842 (wiki/content/deploy/index.md) * https://dgraph.io/docs/query-language/schema/ now has missing content from PR 5842 (wiki/content/query-language/index.md)
Minor wording and typographical updates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a format suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 32 rules errored during the review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 32 rules errored during the review.
Co-authored-by: Damián Parrino <bucanero@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r1, 1 of 1 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aaroncarey, @danielmai, @MichaelJCompton, and @pawanrawal)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @bucanero, @danielmai, @MichaelJCompton, and @pawanrawal)
wiki/content/deploy/dgraph-administration.md, line 34 at r2 (raw file):
Previously, bucanero (Damián Parrino) wrote…
Just for consistency, I'd suggest using code formatting for the endpoint list too:
* `/admin` * `/admin/backup` * `/admin/config/lru_mb` * `/admin/draining` * `/admin/export` * `/admin/shutdown` * `/admin/schema` * `/alter` * `/login`
Done, thanks for the suggestion!
Fixes DGRAPH-2235
This change is
Docs Preview: