feat(Query): Add cacheControl directive that adds headers in the response #6799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
all-seeing-code
requested review from
MichaelJCompton and
pawanrawal
as code owners
github-actions
bot
added
the
area/graphql
gja
approved these changes
Oct 26, 2020
| @@ -343,6 +344,13 @@ func (o *operation) Mutations() (ms []Mutation) { | |||
| return | |||
| } | |||
|
|
|||
| func (o *operation) CacheControl() string { | |||
| if o.op.Directives.ForName(cacheControlDirective) == nil { | |||
| return "" | |||
There was a problem hiding this comment.
private,no-cache would work instead of empty string
There was a problem hiding this comment.
adding header only if the directive is there, otherwise no header.
all-seeing-code
changed the title
abhimanyusinghgaur
approved these changes
Oct 27, 2020
There was a problem hiding this comment.
Reviewed 3 of 5 files at r1, 1 of 2 files at r2, 3 of 46 files at r3.
Reviewable status: 7 of 52 files reviewed, 3 unresolved discussions (waiting on @abhimanyusinghgaur, @anurags92, @gja, @MichaelJCompton, and @pawanrawal)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds support for users to enable browser/CDN side caching for their queries. Users can specify
@cacheControl(maxAge: 15)at the top of their query. This would result in the response being returned with appropriate HTTP headers so that browsers and CDNs can cache the response.More details can be read on discuss.
http headers returned:
This PR fixes: GRAPHQL-722
Components affected by this PR
Does this PR break backwards compatibility?
No
Testing
Added following tests in:
[WIP]
Fixes
Fixes GRAPHQL-722
This change is