Skip to content

chore(bulk): use --tmp directory for temporary buffers #6833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 10, 2020

Conversation

NamanJain8
Copy link
Contributor

@NamanJain8 NamanJain8 commented Nov 3, 2020

Fixes DGRAPH-2617

The bulk loader uses temporary buffers for map-reduce logic. These temporary buffers are created inside /tmp by default.
User may not have a that big /tmp directory and moreover we have a --tmp flag for temporary files in bulk loader. It is expected that we use that directory. So, we should use that instead.


This change is Reviewable

Docs Preview: Dgraph Preview

@github-actions github-actions bot added area/bulk-loader Issues related to bulk loading. area/live-loader Issues related to live loading. labels Nov 3, 2020
Copy link
Contributor

@jarifibrahim jarifibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should delete the buffers after the bulk loader restarts.

@NamanJain8 NamanJain8 merged commit c4d8641 into master Nov 10, 2020
@NamanJain8 NamanJain8 deleted the naman/temp-dir branch November 10, 2020 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bulk-loader Issues related to bulk loading. area/live-loader Issues related to live loading.
Development

Successfully merging this pull request may close these issues.

3 participants