Fix(GraphQL): Add support for using auth with secret directive #6907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/graphql
pawanrawal
approved these changes
Nov 19, 2020
There was a problem hiding this comment.
Reviewed 59 of 59 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @MichaelJCompton)
vmrajas
added a commit
that referenced
this pull request
Nov 19, 2020
* Add password field in auth directive * Add query resolving tests * Add e2e tests * Address feedback (cherry picked from commit 3311923)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Currently, the checkPassword query uses auth rules specified for query.This is problematic for Users trying to use the checkPassword query for authentication. Moreover, the query rewriting in case of auth directive with checkPassword query is not happening properly and an error is thrown.
This PR fixes this.
Testing:
Fixes GRAPHQL-802
This change is