Feat(GraphQL): Add Aggregation Queries at Child Level #7022
Conversation
github-actions
bot
added
the
area/graphql
|
Deploy preview for dgraph-docs ready! Built with commit 2afcbf5 |
There was a problem hiding this comment.
Really nice PR
Reviewed 7 of 7 files at r1.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @MichaelJCompton, @pawanrawal, and @vmrajas)
graphql/resolve/query_rewriter.go, line 1118 at r1 (raw file):
is added.
is not added
graphql/resolve/query_test.yaml, line 2935 at r1 (raw file):
dgraph.uid : uid
can we find a way to not add this for aggregate children?
graphql/resolve/resolver.go, line 1397 at r1 (raw file):
fieldAlias := generateUniqueDgraphAlias(f, fieldSeenCount) aggregateFieldName := aggregateField.Name() aggregateVal[aggregateFieldName] = res[aggregateFieldName+"_"+fieldAlias]
could just be:
aggregateFieldName := aggregateField.Name()
aggregateVal[aggregateFieldName] = res[aggregateFieldName+"_"+uniqueDgraphAlias]
There was a problem hiding this comment.
Reviewable status: 7 of 54 files reviewed, 3 unresolved discussions (waiting on @abhimanyusinghgaur, @MichaelJCompton, and @pawanrawal)
graphql/resolve/query_rewriter.go, line 1118 at r1 (raw file):
Previously, abhimanyusinghgaur (Abhimanyu Singh Gaur) wrote…
is added.is not added
Done.
graphql/resolve/query_test.yaml, line 2935 at r1 (raw file):
Previously, abhimanyusinghgaur (Abhimanyu Singh Gaur) wrote…
dgraph.uid : uidcan we find a way to not add this for aggregate children?
No. This is done by rewriteAsQuery. I believe it is rather harmless to add it. The question of whether adding dgraph.uid to fields is relevant or not is much larger and beyond the scope of aggregation queries.
graphql/resolve/resolver.go, line 1397 at r1 (raw file):
Previously, abhimanyusinghgaur (Abhimanyu Singh Gaur) wrote…
fieldAlias := generateUniqueDgraphAlias(f, fieldSeenCount) aggregateFieldName := aggregateField.Name() aggregateVal[aggregateFieldName] = res[aggregateFieldName+"_"+fieldAlias]could just be:
aggregateFieldName := aggregateField.Name() aggregateVal[aggregateFieldName] = res[aggregateFieldName+"_"+uniqueDgraphAlias]
Done.
vmrajas
force-pushed
the
GRAPHQL-773-child
branch
from
c4c14c2 to
2afcbf5
Compare
Motivation:
This PR adds Aggregation Queries at child level. Aggregation Queries handle Avg,Max,Min,Sum functions for scalar fields.
Related RFC: https://discuss.dgraph.io/t/count-queries-in-graphql/10714/9
This PR contains the following changes:
Fixes GRAPHQL-773
This change is