fix(GraphQL): This PR addd input coercion from single object to list and fix panic when we pass single ID in filter as a string. #7133 #7306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and fix panic when we pass single ID in filter as a string. (#7133) Fixes GRAPHQL-745 Filter with id as a string was giving panic because we were expecting it to be of ["0x1"] type. query { queryAuthor(filter:{id: "0x1"}) { name } } So, we added input coercion such that if we require an object of type list and the input object is scalar then we coerce it to list. (cherry picked from commit 5e5f5ca)
JatinDev543
requested review from
danielmai,
manishrjain,
pawanrawal and
vvbalaji-dgraph
as code owners
github-actions
bot
added
the
area/graphql
pawanrawal
approved these changes
Jan 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GRAPHQL-745
Filter with id as a string was giving panic because we were expecting it to be of ["0x1"] type.
So, we added input coercion such that if we require an object of type list and the input object is scalar then we coerce it to list.
(cherry picked from commit 5e5f5ca)
This change is