release/v20.11 - fix(sort): Make sort consistent for indexed and without indexed predi… #7323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cates (#7241) Make the result of sort consistent for predicate with and without index. After this change, the predicates with null values will appear at the last of the sort result for both ascending and descending sort, for both index/no-index case. Before this change the result for predicate with index didn't contain the null predicates and the one without index treated nulls as infinite value - they appeared at the beginning for descending while at the end for the ascending sort case. NOTE: This is a breaking change for the response of sort. Co-authored-by: Rajas Vanjape <rajas@dgraph.io> (cherry picked from commit 85278f8)
ahsanbarkati
requested review from
danielmai,
manishrjain,
pawanrawal and
vvbalaji-dgraph
as code owners
NamanJain8
approved these changes
Jan 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…cates (#7241)
Make the result of sort consistent for predicate with and without index.
After this change, the predicates with null values will appear at the
last of the sort result for both ascending and descending sort, for both
index/no-index case. Before this change the result for predicate with index
didn't contain the null predicates and the one without index treated nulls as
infinite value - they appeared at the beginning for descending while at the
end for the ascending sort case.
NOTE: This is a breaking change for the response of sort.
Co-authored-by: Rajas Vanjape rajas@dgraph.io
(cherry picked from commit 85278f8)
This change is