-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[Breaking] Consolidate multiple flags into a few SuperFlags #7436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 5 of 103 files reviewed, 11 unresolved discussions (waiting on @danielmai, @karlmcguire, @manishrjain, @martinmr, @pawanrawal, and @vvbalaji-dgraph)
dgraph/cmd/alpha/run.go, line 666 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
ideally, this can just be parsed in the right package instead of here.
Done.
dgraph/cmd/alpha/run.go, line 714 at r1 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
Ideally, worker options only contains the SuperFlags, and lets the modules do what they need to with them.
Done.
dgraph/cmd/alpha/run.go, line 235 at r4 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
no need to use backticks if it fits in one line.
Done.
edgraph/server.go, line 1197 at r4 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
Just ensure that we're not doing this parsing in the critical path.
Done.
(This is related to DGRAPH-3026.)
AlZeBuBaLiDe--badgerbadger.compressioncompressiongoroutinesbadger.cache_mbcache-mbbadger.cache_percentagecache-percentage--aclacl_secret_filesecret-fileacl_access_ttlaccess-ttlacl_refresh_ttlrefresh-ttl--ludicrousludicrous_modeenabledludicrous_concurrencyconcurrency--graphqlgraphql_introspectionintrospectiongraphql_debugdebuggraphql_extensionsextensionsgraphql_poll_intervalpoll-intervalgraphql_lambda_urllambda-url--raftpending_proposalspending-proposalsidxidxgroupgrouplearnerlearnersnapshot-aftersnapshot-after--securityauth_tokentokenwhitelistwhitelist--limitquery_edge_limitquery-edgenormalize_node_limitnormalize-nodemutations_nquad_limitmutations-nquad--tlstls_cacertcacerttls_use_system_cause-system-catls_server_nameserver-nametls_client_authclient-authtls_node_certnode-certtls_node_keynode-keytls_internal_port_enabledinternal-port-enabledtls_certcerttls_keykey--tracetraceratiojaeger.collectorjaegerdatadog.collectordatadog--vaultvault_addraddrvault_roleid_filerole-id-filevault_secretid_filesecret-id-filevault_pathpathvault_fieldfieldvault_formatformatExample
Previously you could use ACL flags like this:
After this PR:
This change is