Fix(rollups): Fix splits in roll-up #7609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarifibrahim
approved these changes
Mar 22, 2021
There was a problem hiding this comment.
The PR looks good to me. Can we please add a test for this @ahsanbarkati ?
skrdgraph
pushed a commit
that referenced
this pull request
Aug 16, 2022
Fix roll-up split generation by fixing the range of UIDs to keep in the first and second part of the split.
joshua-goldstein
pushed a commit
that referenced
this pull request
Aug 23, 2022
Fix(rollups): Fix splits in roll-up (#7609) Fix roll-up split generation by fixing the range of UIDs to keep in the first and second part of the split.
joshua-goldstein
pushed a commit
that referenced
this pull request
Sep 15, 2022
Fix(rollups): Fix splits in roll-up (#7609) Fix roll-up split generation by fixing the range of UIDs to keep in the first and second part of the split.
joshua-goldstein
pushed a commit
that referenced
this pull request
Sep 19, 2022
Fix(rollups): Fix splits in roll-up (#7609) Fix roll-up split generation by fixing the range of UIDs to keep in the first and second part of the split.
joshua-goldstein
added a commit
that referenced
this pull request
Sep 26, 2022
* cherry-pick-7609 Fix(rollups): Fix splits in roll-up (#7609) Fix roll-up split generation by fixing the range of UIDs to keep in the first and second part of the split. * resolve conflict * resolve more conflicts * resolve more conflicts * remove newline * remove whitespace Co-authored-by: Ahsan Barkati <ahsanbarkati@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue with split creation in roll-up. When a part
pis splitinto two parts say
p1andp2then the first UID ofp2should be greaterthan the last UID of p1. This was being violated because of removing UIDs
until
maxInt64instead ofmaxUint64frompin order to createp1.This PR fixes this issue and also removes some unwanted codes.
This change is