Skip to content

chore(test): Remove Ratel from tests and example configs. #7738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Apr 23, 2021

Conversation

danielmai
Copy link
Contributor

@danielmai danielmai commented Apr 20, 2021


This change is Reviewable

Copy link
Contributor

@darkn3rd darkn3rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have all of the contributions been tested as functional:

  • CloudFormation (contrib/config/marketplace)
  • Backups (client, gcp, azure, nfs, s3)
  • Kubernetes (single, ha)
  • Terraform / AWS (contrib/config/terraform/aws)
  • Terraform / GCP (contrib/config/terraform/gcp)
  • Terrafrom / K8S (contrib/config/terraform/kubernetes)
  • Systemd / CentOS (contrib/systemd/centos)
  • Standalone

@danielmai danielmai merged commit f896081 into master Apr 23, 2021
@danielmai danielmai deleted the danielmai/remove-ratel branch April 23, 2021 03:22
@1Const1
Copy link

1Const1 commented Apr 23, 2021

Could you please explain why you removed ratel everywhere? If someone want it they can do it by themselves

@aranwe
Copy link

aranwe commented Jun 9, 2021

I assume these configs are used in CI - however they are directly linked from documentation: https://dgraph.io/docs/deploy/kubernetes/ and without Ratel the Test Single Server Setup (and the Test Dgraph HA Cluster Setup ) doesn't work :)

@tonicebrian
Copy link

I assume these configs are used in CI - however they are directly linked from documentation: https://dgraph.io/docs/deploy/kubernetes/ and without Ratel the Test Single Server Setup (and the Test Dgraph HA Cluster Setup ) doesn't work :)

I'm exactly at this point. Trying to test DGraph following those instructions and stuck because I haven't Ratel. How can I install it in any of those clusters?

@danhawkins
Copy link

Not sure how to get a browser UI up for docker compose now ratel is moved 😕

@rzyns
Copy link

rzyns commented Jul 27, 2021

If Ratel is removed from all of the example configs, shouldn't the documentation be updated? I'd be happy to submit a PR removing references to Ratel in the documentation if someone wants to point me in the right direction. OTOH, I think it might be better if there were alternative instructions, and I'm still just getting my feet wet with dgraph

@BrunoPujos
Copy link

Hello,

So I have a small project where I need a graph database and I decided to try and use DGraph for it. I never used it before so please keep in mind that I have no idea how your software works. Anyway I tried to follow your tutorials:

Both of those (which seems the official ones, if I'm correct) encourage to use Ratel, however your last release does not seems to include Ratel. It seems to have been deleted by this PR. It is absolutely not clear to me why it has been removed or if there is any replacement. I suppose there is a good reason for this but, from a new user point of view, this is really disturbing. If the experience for new user is an important point for you, you may want to either: update your tutorials or make a docker version with Ratel specifically for your tutorials.

Anyway for people encountering this same problem, running: docker run --rm -it -p "8080:8080" -p "9080:9080" -p "8000:8000" -v ~/dgraph:/dgraph "dgraph/standalone:v21.03.0" (so the release before the last one at the time of this comment) seems to work just fine.

Have a nice day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

8 participants