fix(GraphQL): fix auth query rewriting with ID filter #7740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/graphql
pawanrawal
approved these changes
Apr 21, 2021
There was a problem hiding this comment.
Should also be cherry-picked to 21.03?
Reviewed 5 of 5 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @minhaj-shakeel)
graphql/resolve/query_rewriter.go, line 640 at r1 (raw file):
ids := idFilter(extractQueryFilter(field), fieldType.IDField()) if authRw != nil && (authRw.isWritingAuth || authRw.filterByUid) &&
This if condition is so complex and hard to understand. Needs to be looked at and more comments added.
minhaj-shakeel
commented
Apr 22, 2021
There was a problem hiding this comment.
Yeah, will create a cherry-pick after merging it.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @pawanrawal)
graphql/resolve/query_rewriter.go, line 640 at r1 (raw file):
Previously, pawanrawal (Pawan Rawal) wrote…
This
ifcondition is so complex and hard to understand. Needs to be looked at and more comments added.
Will try to add some comments here.
minhaj-shakeel
added a commit
that referenced
this pull request
Apr 22, 2021
Fixes GRAPHQL-1159. (cherry picked from commit 355eea4)
joshua-goldstein
pushed a commit
that referenced
this pull request
Aug 19, 2022
everything else part of PR fix(GraphQL): fix auth query rewriting with ID filter (#7740) Fixes GRAPHQL-1159.
joshua-goldstein
pushed a commit
that referenced
this pull request
Sep 15, 2022
fix(GraphQL): fix auth query rewriting with ID filter (#7740) Fixes GRAPHQL-1159.
joshua-goldstein
pushed a commit
that referenced
this pull request
Sep 19, 2022
fix(GraphQL): fix auth query rewriting with ID filter (#7740) Fixes GRAPHQL-1159.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GRAPHQL-1159.
This change is