Fix(GraphQL): Make mutation rewriting tests more robust #7768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/graphql
pawanrawal
approved these changes
Apr 30, 2021
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @abhimanyusinghgaur)
all-seeing-code
pushed a commit
that referenced
this pull request
Nov 22, 2022
* Make mutation rewriting tests more robust * Fix lint
meghalims
pushed a commit
that referenced
this pull request
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Auth Mutation rewriting tests now also ensure that the mutation returned a false for success in case of error. This PR fixes related tests.
This PR also fixes a potential bug where in in spite of failing on auth, the mutation would have succeeded without throwing an error.
This change is