fix(Dgraph): Forward task status requests to correct Alpha #7774
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajeetdsouza
requested review from
manishrjain,
pawanrawal and
vvbalaji-dgraph
as code owners
github-actions
bot
added
the
area/graphql
manishrjain
approved these changes
May 3, 2021
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ajeetdsouza, @jarifibrahim, @pawanrawal, and @vvbalaji-dgraph)
worker/queue.go, line 155 at r1 (raw file):
switch meta.Status() { case TaskStatusFailed: return 0, fmt.Errorf("an error occurred, please check logs for details")
Just say "task failed"
ajeetdsouza
added a commit
that referenced
this pull request
May 5, 2021
ajeetdsouza
added a commit
that referenced
this pull request
May 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Task API only knows about tasks created by itself. This PR would allow tasks to extract the Raft ID from the Task ID, and use it to forward the request to the correct Alpha.
This change is