opt(snapshot): optimize snapshot by using sinceTs #7826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/schema
ajeetdsouza
reviewed
May 18, 2021
NamanJain8
force-pushed
the
naman/optimize-snapshot
branch
from
3d26782 to
c40ce04
Compare
ahsanbarkati
approved these changes
May 18, 2021
manishrjain
approved these changes
May 18, 2021
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ajeetdsouza and @vvbalaji-dgraph)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not using
stream.SinceTsin snapshot transfer. Instead, we were usingChooseKeyto skip the keys with a lesser version. This can be very slow and memory heavy, because we will have to iterate over the entire DB and skip the keys. UsingSinceTs, we will be skipping the entire table.This change is