fix(restore): consider the banned namespaces while bumping #7839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NamanJain8
force-pushed
the
naman/restore-nsid
branch
from
c8563b0 to
e5f3476
Compare
NamanJain8
changed the title
jarifibrahim
approved these changes
May 20, 2021
NamanJain8
added a commit
that referenced
this pull request
May 24, 2021
We were not considering the banned namespaces while bumping the lease. So, if we restore a backup with namespace 0,1,2 not-banned and 3,4 banned. We will bump only up to 2. This would error out when creating a namespace. (cherry picked from commit 391f8b0)
mangalaman93
pushed a commit
that referenced
this pull request
Jan 4, 2023
We were not considering the banned namespaces while bumping the lease. So, if we restore a backup with namespace 0,1,2 not-banned and 3,4 banned. We will bump only up to 2. This would error out when creating a namespace.
mangalaman93
pushed a commit
that referenced
this pull request
Jan 4, 2023
We were not considering the banned namespaces while bumping the lease. So, if we restore a backup with namespace 0,1,2 not-banned and 3,4 banned. We will bump only up to 2. This would error out when creating a namespace.
mangalaman93
pushed a commit
that referenced
this pull request
Jan 4, 2023
We were not considering the banned namespaces while bumping the lease. So, if we restore a backup with namespace 0,1,2 not-banned and 3,4 banned. We will bump only up to 2. This would error out when creating a namespace.
mangalaman93
pushed a commit
that referenced
this pull request
Jan 6, 2023
We were not considering the banned namespaces while bumping the lease. So, if we restore a backup with namespace 0,1,2 not-banned and 3,4 banned. We will bump only up to 2. This would error out when creating a namespace.
mangalaman93
pushed a commit
that referenced
this pull request
Jan 17, 2023
We were not considering the banned namespaces while bumping the lease. So, if we restore a backup with namespace 0,1,2 not-banned and 3,4 banned. We will bump only up to 2. This would error out when creating a namespace.
mangalaman93
pushed a commit
that referenced
this pull request
Jan 18, 2023
We were not considering the banned namespaces while bumping the lease. So, if we restore a backup with namespace 0,1,2 not-banned and 3,4 banned. We will bump only up to 2. This would error out when creating a namespace.
mangalaman93
pushed a commit
that referenced
this pull request
Jan 20, 2023
We were not considering the banned namespaces while bumping the lease. So, if we restore a backup with namespace 0,1,2 not-banned and 3,4 banned. We will bump only up to 2. This would error out when creating a namespace.
mangalaman93
pushed a commit
that referenced
this pull request
Jan 24, 2023
We were not considering the banned namespaces while bumping the lease. So, if we restore a backup with namespace 0,1,2 not-banned and 3,4 banned. We will bump only up to 2. This would error out when creating a namespace.
all-seeing-code
pushed a commit
that referenced
this pull request
Jan 25, 2023
…8559) We were not considering the banned namespaces while bumping the lease. So, if we restore a backup with namespace 0,1,2 not-banned and 3,4 banned. We will bump only up to 2. This would error out when creating a namespace Co-authored-by: Naman Jain <naman@dgraph.io>
all-seeing-code
pushed a commit
that referenced
this pull request
Feb 8, 2023
…8559) We were not considering the banned namespaces while bumping the lease. So, if we restore a backup with namespace 0,1,2 not-banned and 3,4 banned. We will bump only up to 2. This would error out when creating a namespace Co-authored-by: Naman Jain <naman@dgraph.io>
all-seeing-code
pushed a commit
that referenced
this pull request
Feb 8, 2023
…8559) We were not considering the banned namespaces while bumping the lease. So, if we restore a backup with namespace 0,1,2 not-banned and 3,4 banned. We will bump only up to 2. This would error out when creating a namespace Co-authored-by: Naman Jain <naman@dgraph.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not considering the banned namespaces while bumping the lease. So, if we restore a backup with namespace 0,1,2 not-banned and 3,4 banned. We will bump only up to 2. This would error out when creating a namespace.
This change is