fix(predMove): use the predicate move timestamp to write the schema #7862
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In predicate move, we were using
kv.Versionwhile writing the schema at receiver, but we delete the schema atin.ReadTs. This fails when we move the same tablet from Group 1 -> Group 2 -> Group 1 if the schema for that predicate doesn't change between those 2 moves.This happens because the schema written at t1 was cleaned at timestamp t2 (t2>t1) while doing 1st predicate move. And in 2nd predicate move (G2 -> G1), we were writing the schema back at timestamp t1. Hence, the schema was written below the discard timestamp t2 and does not gets reflected.
(cherry picked from commit 64b71b6)
This change is