Skip to content

Neo4JConvertor(test):Fixed some issues regarding Conversion of Neo4J csv to rdf #7892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

AvinashRatnam608
Copy link

@AvinashRatnam608 AvinashRatnam608 commented Jun 7, 2021

Fixed some issues regarding multi line queries in the Neo4J CSV.
Also enabled ability to log errors using glog.Error().


This change is Reviewable

@CLAassistant
Copy link

CLAassistant commented Jun 7, 2021

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@NamanJain8 NamanJain8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 4 unresolved discussions (waiting on @ahsanbarkati, @AvinashRatnam608, @jarifibrahim, @manishrjain, and @vvbalaji-dgraph)


Neo4JConvertor.go, line 2 at r1 (raw file):

package main

Add license.


Neo4JConvertor.go, line 23 at r1 (raw file):

	inputPath  = flag.String("input", "", "Please provide the input csv file.")
	outputPath = flag.String("output", "", "Where to place the output?")
)

We use viper for comand line options. We should use the same here too for consistency.


Neo4JConvertor.go, line 106 at r1 (raw file):

		records, err := d.ReadAll() //removed err
		//fmt.Println("Testest1")
		//check(err)

Let's remove the comments once it is ready to merge.


Neo4JConvertor.go, line 203 at r1 (raw file):

	}
}
func check(err error) {

We can use x.Check()

Copy link

github-actions bot commented Aug 2, 2024

This PR has been stale for 60 days and will be closed automatically in 7 days. Comment to keep it open.

@github-actions github-actions bot added the Stale label Aug 2, 2024
@github-actions github-actions bot closed this Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants