Skip to content

fix(conn): Reconnect via a redial #7918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2021
Merged

fix(conn): Reconnect via a redial #7918

merged 1 commit into from
Jun 22, 2021

Conversation

manishrjain
Copy link
Contributor

@manishrjain manishrjain commented Jun 22, 2021 •
edited
Loading

In case the heartbeats in a connection pool stop, try to re-establish the connection via a re-dial. That's a more robust way than waiting for current connection to become usable again. This allow much faster recovery from network partitions.

This change is Reviewable

@manishrjain manishrjain merged commit 947a62b into master Jun 22, 2021
@manishrjain manishrjain deleted the mrjn/reconnect branch June 22, 2021 20:57
danielmai pushed a commit that referenced this pull request Jun 22, 2021
@manishrjain @danielmai
Reconnect via a redial in case of disconnection. (#7918)
fcf2b48 
In case the heartbeats in a connection pool stop, try to re-establish the connection via a redial. That's a more robust way than waiting for current connection to become usable again and allows much faster recovery from network partitions.

(cherry picked from commit 947a62b)
danielmai pushed a commit that referenced this pull request Jun 22, 2021
@manishrjain @danielmai
Reconnect via a redial in case of disconnection. (#7918)
275df65 
In case the heartbeats in a connection pool stop, try to re-establish the connection via a redial. That's a more robust way than waiting for current connection to become usable again and allows much faster recovery from network partitions.

(cherry picked from commit 947a62b)
danielmai pushed a commit that referenced this pull request Jun 22, 2021
@manishrjain @danielmai
Reconnect via a redial in case of disconnection. (#7918)
3e55502 
In case the heartbeats in a connection pool stop, try to re-establish the connection via a redial. That's a more robust way than waiting for current connection to become usable again and allows much faster recovery from network partitions.

(cherry picked from commit 947a62b)
danielmai pushed a commit that referenced this pull request Jun 22, 2021
@manishrjain @danielmai
Reconnect via a redial in case of disconnection. (#7918)
0d0be76 
In case the heartbeats in a connection pool stop, try to re-establish the connection via a redial. That's a more robust way than waiting for current connection to become usable again and allows much faster recovery from network partitions.

(cherry picked from commit 947a62b)
danielmai added a commit that referenced this pull request Jun 22, 2021
@danielmai @manishrjain
Reconnect via a redial in case of disconnection. (#7918) (#7920)
6b22208 
In case the heartbeats in a connection pool stop, try to re-establish the connection via a redial. That's a more robust way than waiting for current connection to become usable again and allows much faster recovery from network partitions.

(cherry picked from commit 947a62b)

Co-authored-by: Manish R Jain <manish@dgraph.io>
danielmai added a commit that referenced this pull request Jun 22, 2021
@danielmai @manishrjain
Reconnect via a redial in case of disconnection. (#7918) (#7921)
6e103fb 
In case the heartbeats in a connection pool stop, try to re-establish the connection via a redial. That's a more robust way than waiting for current connection to become usable again and allows much faster recovery from network partitions.

(cherry picked from commit 947a62b)

Co-authored-by: Manish R Jain <manish@dgraph.io>
danielmai added a commit that referenced this pull request Jun 22, 2021
@danielmai @manishrjain
Reconnect via a redial in case of disconnection. (#7918) (#7922)
17f52bc 
In case the heartbeats in a connection pool stop, try to re-establish the connection via a redial. That's a more robust way than waiting for current connection to become usable again and allows much faster recovery from network partitions.

(cherry picked from commit 947a62b)

Co-authored-by: Manish R Jain <manish@dgraph.io>
@manishrjain manishrjain mentioned this pull request Jul 16, 2021
Merged
manishrjain added a commit that referenced this pull request Jul 16, 2021
@manishrjain
fix(conn): JoinCluster loop should use latest conn (#7950)
7531e95 
JoinCluster loop was getting the connection from pool upfront, and then looping over it. This opened up a bug because in #7918 , we close the connection in case it becomes unhealthy.

This PR gets the latest connection available in the loop. This was the only place in the codebase where I found this issue.
danielmai pushed a commit that referenced this pull request Jul 16, 2021
@manishrjain @danielmai
fix(conn): JoinCluster loop should use latest conn (#7950)
c704b0c 
JoinCluster loop was getting the connection from pool upfront, and then looping over it. This opened up a bug because in #7918 , we close the connection in case it becomes unhealthy.

This PR gets the latest connection available in the loop. This was the only place in the codebase where I found this issue.

(cherry picked from commit 7531e95)
@danielmai danielmai mentioned this pull request Jul 16, 2021
Merged
danielmai pushed a commit that referenced this pull request Jul 16, 2021
@manishrjain @danielmai
fix(conn): JoinCluster loop should use latest conn (#7950)
788b959 
JoinCluster loop was getting the connection from pool upfront, and then looping over it. This opened up a bug because in #7918 , we close the connection in case it becomes unhealthy.

This PR gets the latest connection available in the loop. This was the only place in the codebase where I found this issue.

(cherry picked from commit 7531e95)
@danielmai danielmai mentioned this pull request Jul 16, 2021
Merged
danielmai pushed a commit that referenced this pull request Jul 16, 2021
@manishrjain @danielmai
fix(conn): JoinCluster loop should use latest conn (#7950)
c4098ed 
JoinCluster loop was getting the connection from pool upfront, and then looping over it. This opened up a bug because in #7918 , we close the connection in case it becomes unhealthy.

This PR gets the latest connection available in the loop. This was the only place in the codebase where I found this issue.

(cherry picked from commit 7531e95)
@danielmai danielmai mentioned this pull request Jul 16, 2021
Merged
danielmai pushed a commit that referenced this pull request Jul 16, 2021
@manishrjain @danielmai
fix(conn): JoinCluster loop should use latest conn (#7950)
3608786 
JoinCluster loop was getting the connection from pool upfront, and then looping over it. This opened up a bug because in #7918 , we close the connection in case it becomes unhealthy.

This PR gets the latest connection available in the loop. This was the only place in the codebase where I found this issue.

(cherry picked from commit 7531e95)
(cherry picked from commit c4098ed)
@danielmai danielmai mentioned this pull request Jul 16, 2021
Merged
danielmai added a commit that referenced this pull request Jul 16, 2021
@danielmai @manishrjain
fix(conn): JoinCluster loop should use latest conn (#7950) (#7951)
88e4aa0 
JoinCluster loop was getting the connection from pool upfront, and then looping over it. This opened up a bug because in #7918 , we close the connection in case it becomes unhealthy.

This PR gets the latest connection available in the loop. This was the only place in the codebase where I found this issue.

(cherry picked from commit 7531e95)

Co-authored-by: Manish R Jain <manish@dgraph.io>
danielmai added a commit that referenced this pull request Jul 16, 2021
@danielmai @manishrjain
fix(conn): JoinCluster loop should use latest conn (#7950) (#7952)
7f51327 
JoinCluster loop was getting the connection from pool upfront, and then looping over it. This opened up a bug because in #7918 , we close the connection in case it becomes unhealthy.

This PR gets the latest connection available in the loop. This was the only place in the codebase where I found this issue.

(cherry picked from commit 7531e95)

Co-authored-by: Manish R Jain <manish@dgraph.io>
danielmai added a commit that referenced this pull request Jul 16, 2021
@danielmai @manishrjain
fix(conn): JoinCluster loop should use latest conn (#7950) (#7953)
9e0118c 
JoinCluster loop was getting the connection from pool upfront, and then looping over it. This opened up a bug because in #7918 , we close the connection in case it becomes unhealthy.

This PR gets the latest connection available in the loop. This was the only place in the codebase where I found this issue.

(cherry picked from commit 7531e95)

Co-authored-by: Manish R Jain <manish@dgraph.io>
danielmai added a commit that referenced this pull request Jul 16, 2021
@danielmai @manishrjain
fix(conn): JoinCluster loop should use latest conn (#7950) (#7954)
07452e8 
JoinCluster loop was getting the connection from pool upfront, and then looping over it. This opened up a bug because in #7918 , we close the connection in case it becomes unhealthy.

This PR gets the latest connection available in the loop. This was the only place in the codebase where I found this issue.

(cherry picked from commit 7531e95)
(cherry picked from commit c4098ed)

Co-authored-by: Manish R Jain <manish@dgraph.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@manishrjain