Skip to content

fix(restore): Set kv version to restoreTs for rolled up keys and schema keys #7930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 28, 2021
Merged

fix(restore): Set kv version to restoreTs for rolled up keys and schema keys #7930

merged 2 commits into from
Jun 28, 2021

Conversation

ahsanbarkati
Copy link
Contributor

@ahsanbarkati ahsanbarkati commented Jun 25, 2021 •
edited
Loading

The kv version should be set to restore timestamp for rolled-up keys and schema keys as well.

NOTE: I need to double-check if writing schema to restoreTs is right thing to do.

This change is Reviewable

@ahsanbarkati ahsanbarkati changed the title fix(restore): Set kv version to restoreTs for rolled up keys fix(restore): Set kv version to restoreTs for rolled up keys and schema keys Jun 28, 2021
NamanJain8
NamanJain8 approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@NamanJain8 NamanJain8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahsanbarkati ahsanbarkati merged commit 01ee32f into release/v21.03-slash Jun 28, 2021
@ahsanbarkati ahsanbarkati deleted the ahsan/fix-restore-version branch June 28, 2021 09:02
ahsanbarkati added a commit that referenced this pull request Jun 28, 2021
@ahsanbarkati
fix(restore): Set kv version to restoreTs for rolled up keys and sche…
1e983ba 
…ma keys (#7930)

The kv version should be set to restore timestamp for rolled-up keys
and schema keys as well.

(cherry picked from commit 01ee32f)
ahsanbarkati added a commit that referenced this pull request Jun 28, 2021
@ahsanbarkati
fix(restore): Set kv version to restoreTs for rolled up keys and sche…
a06cf2d 
…ma keys (#7930) (#7935)

The kv version should be set to restore timestamp for rolled-up keys
and schema keys as well.
mangalaman93 pushed a commit that referenced this pull request Jan 4, 2023
@ahsanbarkati @mangalaman93
fix(restore): Set kv version to restoreTs for all keys (#7930)
05bae0f 
The kv version should be set to restore timestamp for rolled-up keys
and schema keys as well.
mangalaman93 pushed a commit that referenced this pull request Jan 6, 2023
@ahsanbarkati @mangalaman93
fix(restore): Set kv version to restoreTs for all keys (#7930)
0985b36 
The kv version should be set to restore timestamp for rolled-up keys
and schema keys as well.
mangalaman93 pushed a commit that referenced this pull request Jan 17, 2023
@ahsanbarkati @mangalaman93
fix(restore): Set kv version to restoreTs for all keys (#7930)
8c8102e 
The kv version should be set to restore timestamp for rolled-up keys
and schema keys as well.
mangalaman93 pushed a commit that referenced this pull request Jan 18, 2023
@ahsanbarkati @mangalaman93
fix(restore): Set kv version to restoreTs for all keys (#7930)
c129021 
The kv version should be set to restore timestamp for rolled-up keys
and schema keys as well.
mangalaman93 pushed a commit that referenced this pull request Jan 20, 2023
@ahsanbarkati @mangalaman93
fix(restore): Set kv version to restoreTs for all keys (#7930)
b7c2cdd 
The kv version should be set to restore timestamp for rolled-up keys
and schema keys as well.
mangalaman93 added a commit that referenced this pull request Feb 1, 2023
@mangalaman93
fix(restore): Set kv version to restoreTs for all keys (#7930)
cbe1a11 
The kv version should be set to restore timestamp for rolled-up keys
and schema keys as well.
mangalaman93 added a commit that referenced this pull request Feb 1, 2023
@mangalaman93
fix(restore): Set kv version to restoreTs for all keys (#7930)
7f72777 
The kv version should be set to restore timestamp for rolled-up keys
and schema keys as well.
mangalaman93 added a commit that referenced this pull request Feb 2, 2023
@mangalaman93
fix(restore): Set kv version to restoreTs for all keys (#7930) (#8563)
b100a90 
The kv version should be set to restore timestamp for rolled-up keys and
schema keys as well. It would be inconsistent to write data at different
timestamp compared to the timestamp that we use for writing schema keys.
all-seeing-code pushed a commit that referenced this pull request Feb 8, 2023
@mangalaman93 @all-seeing-code
fix(restore): Set kv version to restoreTs for all keys (#7930) (#8563)
ff8fe2a 
The kv version should be set to restore timestamp for rolled-up keys and
schema keys as well. It would be inconsistent to write data at different
timestamp compared to the timestamp that we use for writing schema keys.
all-seeing-code pushed a commit that referenced this pull request Feb 8, 2023
@mangalaman93 @all-seeing-code
fix(restore): Set kv version to restoreTs for all keys (#7930) (#8563)
77a9c6a 
The kv version should be set to restore timestamp for rolled-up keys and
schema keys as well. It would be inconsistent to write data at different
timestamp compared to the timestamp that we use for writing schema keys.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NamanJain8 NamanJain8 NamanJain8 approved these changes

@manishrjain manishrjain Awaiting requested review from manishrjain

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahsanbarkati @NamanJain8