opt(Alpha): Load schema and types using Stream framework #7938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area/schema
NamanJain8
approved these changes
Jul 2, 2021
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @danielmai and @manishrjain)
schema/schema.go, line 521 at r2 (raw file):
return nil, err } glog.Fatalf("Invalid load type")
return statement after fatal?
manishrjain
commented
Jul 2, 2021
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @danielmai and @NamanJain8)
schema/schema.go, line 521 at r2 (raw file):
Previously, NamanJain8 (Naman Jain) wrote…
return statement after fatal?
Yeah, otherwise, Go doesn't compile this.
NamanJain8
pushed a commit
that referenced
this pull request
Jul 2, 2021
For big datasets, we're seeing a big slowdown due to loading schema and types serially using a single iterator. Using the Stream framework, makes this metadata loading step much faster, resulting in a much faster Alpha initialization. (cherry picked from commit d03d5ad)
NamanJain8
pushed a commit
that referenced
this pull request
Jul 2, 2021
For big datasets, we're seeing a big slowdown due to loading schema and types serially using a single iterator. Using the Stream framework, makes this metadata loading step much faster, resulting in a much faster Alpha initialization. (cherry picked from commit d03d5ad)
NamanJain8
added a commit
that referenced
this pull request
Jul 2, 2021
For big datasets, we're seeing a big slowdown due to loading schema and types serially using a single iterator. Using the Stream framework, makes this metadata loading step much faster, resulting in a much faster Alpha initialization. (cherry picked from commit d03d5ad) Co-authored-by: Manish R Jain <manish@dgraph.io>
NamanJain8
added a commit
that referenced
this pull request
Jul 2, 2021
For big datasets, we're seeing a big slowdown due to loading schema and types serially using a single iterator. Using the Stream framework, makes this metadata loading step much faster, resulting in a much faster Alpha initialization. (cherry picked from commit d03d5ad) Co-authored-by: Manish R Jain <manish@dgraph.io>
mangalaman93
pushed a commit
that referenced
this pull request
Jan 4, 2023
) For big datasets, we're seeing a big slowdown due to loading schema and types serially using a single iterator. Using the Stream framework, makes this metadata loading step much faster, resulting in a much faster Alpha initialization. (cherry picked from commit d03d5ad)
mangalaman93
pushed a commit
that referenced
this pull request
Jan 17, 2023
) For big datasets, we're seeing a big slowdown due to loading schema and types serially using a single iterator. Using the Stream framework, makes this metadata loading step much faster, resulting in a much faster Alpha initialization. (cherry picked from commit d03d5ad)
mangalaman93
pushed a commit
that referenced
this pull request
Jan 17, 2023
) For big datasets, we're seeing a big slowdown due to loading schema and types serially using a single iterator. Using the Stream framework, makes this metadata loading step much faster, resulting in a much faster Alpha initialization. (cherry picked from commit d03d5ad)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For big datasets, we're seeing a big slowdown due to loading schema and types serially using a single iterator. Using the Stream framework, makes this metadata loading step much faster, resulting in a much faster Alpha initialization.
This change is