fix(query): Do not execute filters if there are no source uids #7962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manishrjain
reviewed
Jul 28, 2021
There was a problem hiding this comment.
Seems like a generally reasonable change.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
ahsanbarkati
added a commit
that referenced
this pull request
Aug 2, 2021
No need to execute filter subgraph if there are no source UIDs. (cherry picked from commit 849b587)
ahsanbarkati
added a commit
that referenced
this pull request
Aug 2, 2021
all-seeing-code
pushed a commit
that referenced
this pull request
Nov 23, 2022
all-seeing-code
pushed a commit
that referenced
this pull request
Nov 28, 2022
all-seeing-code
added a commit
that referenced
this pull request
Nov 29, 2022
#8452) No need to execute filter subgraph if there are no source UIDs. (cherry picked from commit 849b587) ## Description The original PR adds a fail fast methodology, where it doesn't expand on a filter subgraph if the srcUid is nil. The current cherry-pick PR brings that change in and adds a test case that scenario. ## Test `TestFilterWithNoSrcUid` Co-authored-by: Ahsan Barkati <ahsan@dgraph.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to execute filter subgraph if there are no source UIDs.
This change is