fix(contrib/k8s): allow to deploy to cluster with domain name #7976
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
danielmai
approved these changes
Aug 11, 2021
There was a problem hiding this comment.
Thanks @hongbo-miao for the PR. This might affect the cluster connectivity for other folks depending on their DNS configuration in their Kubernetes cluster. But, if this helps you, let's merge this PR and then we can update the example later if others are seeing new issues.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @hongbo-miao)
danielmai
changed the title
This was referenced Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we cannot deploy to a cluster with a cluster domain name.
This removes the hard coded
.svc.cluster.localand help Dgraph be deployed to any cluster with or without cluster domain name.More context at https://discuss.dgraph.io/t/failed-to-install-dgraph-ha/15198
This change is