Skip to content

fix(codec): Return nil instead of a new bitmap #7997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 25, 2021
Merged

fix(codec): Return nil instead of a new bitmap #7997

merged 1 commit into from
Aug 25, 2021

Conversation

ahsanbarkati
Copy link
Contributor

@ahsanbarkati ahsanbarkati commented Aug 25, 2021 •
edited
Loading

Return nil in from FromListWithCopy instead of a new bitmap.
We should also do the same for FromList.

NOTE: we'll soon make sroar to better handle the nils so that we can return nil and don't
worry about it in dgraph.

This change is Reviewable

@ahsanbarkati ahsanbarkati merged commit 466982d into master Aug 25, 2021
@ahsanbarkati ahsanbarkati deleted the ahsan/manage-nils branch August 25, 2021 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manishrjain manishrjain Awaiting requested review from manishrjain

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ahsanbarkati