fix(snapshot): Fix snapshot calculation after restore #8024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NamanJain8
reviewed
Sep 14, 2021
manishrjain
suggested changes
Sep 15, 2021
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @ahsanbarkati)
worker/draft.go, line 2045 at r1 (raw file):
// purpose of snapshot calculation. if proposal.Restore != nil { restoreTs := proposal.Restore.GetRestoreTs()
If we did a restore, then we should just overwrite the timestamp to use the restore timestamp. But, does the restore TS get correctly picked up?
NamanJain8
reviewed
Sep 15, 2021
worker/draft.go
Outdated
| // a snapshot. This is to avoid the restore happening again if the server restarts. | ||
| if proposal.Restore != nil { | ||
| restoreTs := proposal.Restore.GetRestoreTs() | ||
| glog.Infof("Found restore proposal with restoreTs: %d", restoreTs) |
There was a problem hiding this comment.
Add a log like calculated snapshot from the restore proposal and maybe dump the snapshot as well in the logs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is no delta proposal with a valid commit then the snapshot was
skipped. For the purpose of snapshot calculation, we should also
consider the restore timestamp.
This change is