Changing type of Value

[pawanrawal]

This change is

[manishrjain]

Review status: 0 of 9 files reviewed at latest revision, 1 unresolved discussion.

---

posting/list.go, line 206 [r2] (raw file):

}

func ParseValue(value []byte) ([]byte, error) {

You don't really need this function. The small value[0] = 0x00 check is probably not required either -- maybe we can just stop setting the value to 0x00, now that we no longer do json encoding.

---

Comments from Reviewable

[manishrjain]

Reviewed 2 of 8 files at r1, 7 of 7 files at r2.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

Comments from Reviewable

[pawanrawal]

Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

posting/list.go, line 206 [r2] (raw file):

Previously, manishrjain (Manish R Jain) wrote…

You don't really need this function. The small value[0] = 0x00 check is probably not required either -- maybe we can just stop setting the value to 0x00, now that we no longer do json encoding.

I was wondering if we need it anymore. Where do we set the 0x00 value?

---

Comments from Reviewable

[pawanrawal]

Review status: 2 of 9 files reviewed at latest revision, 2 unresolved discussions.

---

query/query_test.go, line 273 [r3] (raw file):

          t.Error("Unable to retrieve value")
      }
      if !bytes.Equal(tv.ValBytes(), []byte{}) {

This is the failing test which I changed now.

---

Comments from Reviewable

[manishrjain]

Please merge only after squashing your commits, and then merge using commandline.

Previously, pawanrawal (Pawan Rawal) wrote…

Changing type of Value

---

Reviewed 7 of 7 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

query/query_test.go, line 273 [r3] (raw file):

Previously, pawanrawal (Pawan Rawal) wrote…

This is the failing test which I changed now.

OK

---

Comments from Reviewable

[pawanrawal]

Merged.