[Breaking] fix(GraphQL): fix validation when we give non-string value in variable and expected type is string. #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhimanyusinghgaur
approved these changes
Feb 26, 2021
JatinDev543
changed the title
JatinDev543
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we give variables in a request, then those are unmarshaled in dgraph code where any Int or Float is unmarshaled to
json.Number.While validating in gqlParser library we were checking
Type.Kind()of these variables which is stillstring. So, we were not generating any error if we giveIntorFloatvalue and expected type isstring. That is a bug and in our dgraph code it is giving a panic because we expected a string value but sometimes gotIntorFloat.So now instead of
Type.Kind()we compareType().Name()of variable which will giveNumberif given variable isInt or Float.This change will also make our implementation Graphql spec complaint.