Accept i18n in type and field names #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ A review job has been created and sent to the PullRequest network.
Check the status or cancel PullRequest code review here.
This was referenced Sep 17, 2019
There was a problem hiding this comment.
Suggest using noop function as before. Add filter to test function to make it more readable. getQuery functionality can be moved to a function.
Reviewed with ❤️ by PullRequest
| elements.map(el => el.textContent), | ||
| ); | ||
|
|
||
| const idx = texts.findIndex(t => t.indexOf(textContent) >= 0); |
There was a problem hiding this comment.
I think it would be more readable to .filter() in the async block above and check the length here and return elements[0].
There was a problem hiding this comment.
I don't see how to make it readable with filter() -- note we take index from one array but return an element with that index from another array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is