Add dropboxes to UI to choose which type do uid fields point to #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pullrequest[bot]](https://avatars.githubusercontent.com/in/3434?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ A review job has been created and sent to the PullRequest network.
Check the status or cancel PullRequest code review here.
There was a problem hiding this comment.
Suggest creating a function for getTypeFieldValues. Replace the reduce and remove Object.assign if it is not necessary.
Reviewed with ❤️ by PullRequest
| s[0] === "[" && s[s.length - 1] === "]" ? s.slice(1, s.length - 1) : s; | ||
| const typeFieldValues = isCreate | ||
| ? {} | ||
| : type.fields.reduce( |
There was a problem hiding this comment.
This can be moved to another function, eg getTypeFieldValues
| ${fields | ||
| .map( | ||
| f => | ||
| `<${f.name}>: ${ |
There was a problem hiding this comment.
This could use selectedTypes[f.name] || f.type
| ? {} | ||
| : type.fields.reduce( | ||
| (acc, f) => | ||
| Object.assign(acc, { [f.name]: removeBrackets(f.type) }), |
There was a problem hiding this comment.
It doesn't seem like Object.assign is needed here. I also think it would be simpler here to write something like:
const typeFieldValues = {};
if (!isCreate) {
for (const f in type.fields) {
typeFieldValues[f.name] = removeBrackets(f.type)
}
}
Rather than using reduce.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is