Skip to content

Add a schema management tab #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 8, 2018
Merged

Add a schema management tab #5

merged 7 commits into from
Jan 8, 2018

Conversation

gpahal
Copy link
Contributor

@gpahal gpahal commented Jan 8, 2018

No description provided.

@peterstace
Copy link

Idea: when adding an index (especially for string), it would be cool if there was a link to the index part of the wiki.

@peterstace
Copy link

peterstace commented Jan 8, 2018

It doesn't make too much sense to allow count if non-uid predicates.

EDIT: Hmm, unless it's a list?

@gpahal
Copy link
Contributor Author

gpahal commented Jan 8, 2018

Yes, adding the link is a good idea

@gpahal
Copy link
Contributor Author

gpahal commented Jan 8, 2018

I left count there because it was allowed. I think it would be better if I remove it if it doesn't make any sense elsewhere

@gpahal
Copy link
Contributor Author

gpahal commented Jan 8, 2018

So I can only show count for uids and lists

@peterstace
Copy link

Only showing count for uids and lists sounds good. We should probably also check on the server side too, since this sort of schema could also be set via regular means.

@gpahal
Copy link
Contributor Author

gpahal commented Jan 8, 2018

Currently, it requests directly to Dgraph. So it accepts anything that the Dgraph server accepts.

@peterstace
Copy link

I had a decent play around with it manually, looks pretty good! I took a look at the code as well - could follow the basic idea but don't really know enough JS to truly know how it works.

LGTM.

@gpahal
Copy link
Contributor Author

gpahal commented Jan 8, 2018

Sure. Thanks

@gpahal gpahal merged commit 81fd9be into master Jan 8, 2018
@gpahal gpahal deleted the gp/feature-schema branch January 8, 2018 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants