-
Notifications
You must be signed in to change notification settings - Fork 415
Closed
Labels
kind/enhancementSomething could be better.Something could be better.status/acceptedWe accept to work on it.We accept to work on it.
Description
When an item is deleted by cache.Del(key), we delete it from the store on the following line
https://github.com/dgraph-io/ristretto/blob/a093fe661329ba68a99a9c3a63674992355f40b1/cache.go#L248-L259
the same item is deleted again in the process() goroutine
https://github.com/dgraph-io/ristretto/blob/a093fe661329ba68a99a9c3a63674992355f40b1/cache.go#L331-L334
I don't think there's a major side-effect of doing this but we're doing unnecessary work by deleting an already deleted key.
Metadata
Metadata
Assignees
Labels
kind/enhancementSomething could be better.Something could be better.status/acceptedWe accept to work on it.We accept to work on it.