Add International date format support #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @godban, thanks for the PR! Since there are a lot of variations of date formats, maybe we should go with the most permissive, which I think would be 1-4 numbers, delimiter ( That way all the following would be valid dates: 2018-04-16 What do you think? |
gotbahn
changed the title
|
@ungoldman yea, make sense. Updated |
|
so... what's up, Doc? |
ungoldman
reviewed
Apr 30, 2018
| @@ -4,7 +4,7 @@ var removeMarkdown = require('remove-markdown') | |||
|
|
|||
| // patterns | |||
| var semver = /\[?v?([\w\d.-]+\.[\w\d.-]+[a-zA-Z0-9])\]?/ | |||
| var date = /.*([\d]{4}-[\d]{2}-[\d]{2}).*/ | |||
| var date = /.*[ ](\d\d?\d?\d?[-/.]\d\d?[-/.]\d\d?\d?\d?).*/ | |||
There was a problem hiding this comment.
[ ] is not necessary here (means "one of one whitespace" basically). Otherwise looks good.
|
Hi @godban. Sorry I've been busy. Looks good enough, thanks. |
|
📦 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there, thx for a nice package. As European user, I want to have possibility declare dates in European format
DD-MM-YYYY. This PR extends Date regex with it.