From e9abf8b4d6e4f8e3103f903829754f8c17e22ea8 Mon Sep 17 00:00:00 2001 From: Sanket Mundra Date: Mon, 12 Jun 2023 18:12:33 +0530 Subject: [PATCH 1/2] Logging exception only in case of debug --- .../config/span/processing/utils/SpanFilterMatcher.java | 1 - 1 file changed, 1 deletion(-) diff --git a/span-processing-utils/src/main/java/org/hypertrace/config/span/processing/utils/SpanFilterMatcher.java b/span-processing-utils/src/main/java/org/hypertrace/config/span/processing/utils/SpanFilterMatcher.java index 9a7294bd..b61bfcf0 100644 --- a/span-processing-utils/src/main/java/org/hypertrace/config/span/processing/utils/SpanFilterMatcher.java +++ b/span-processing-utils/src/main/java/org/hypertrace/config/span/processing/utils/SpanFilterMatcher.java @@ -114,7 +114,6 @@ private boolean matches(String lhs, String rhs, RelationalOperator relationalOpe try { return Pattern.compile(rhs).matcher(lhs).find(); } catch (Exception e) { - log.error("Invalid regex: {} passed to match: {}", rhs, e); if (log.isDebugEnabled()) { log.debug( "Invalid regex passed to match. Hence returning false. lhs: {} and rhs: {}", From c5a2345850530e0fda4dffcb1a78ec98e60c5f33 Mon Sep 17 00:00:00 2001 From: Sanket Mundra Date: Mon, 12 Jun 2023 18:17:02 +0530 Subject: [PATCH 2/2] update --- .../config/span/processing/utils/SpanFilterMatcher.java | 1 + 1 file changed, 1 insertion(+) diff --git a/span-processing-utils/src/main/java/org/hypertrace/config/span/processing/utils/SpanFilterMatcher.java b/span-processing-utils/src/main/java/org/hypertrace/config/span/processing/utils/SpanFilterMatcher.java index b61bfcf0..d069ab34 100644 --- a/span-processing-utils/src/main/java/org/hypertrace/config/span/processing/utils/SpanFilterMatcher.java +++ b/span-processing-utils/src/main/java/org/hypertrace/config/span/processing/utils/SpanFilterMatcher.java @@ -114,6 +114,7 @@ private boolean matches(String lhs, String rhs, RelationalOperator relationalOpe try { return Pattern.compile(rhs).matcher(lhs).find(); } catch (Exception e) { + log.error("Invalid regex: {} passed to match", rhs); if (log.isDebugEnabled()) { log.debug( "Invalid regex passed to match. Hence returning false. lhs: {} and rhs: {}",