diff --git a/alerting-config-service-impl/src/main/java/org/hypertrace/alerting/config/service/EventConditionConfigServiceImpl.java b/alerting-config-service-impl/src/main/java/org/hypertrace/alerting/config/service/EventConditionConfigServiceImpl.java index ad2481cf..45aa67ea 100644 --- a/alerting-config-service-impl/src/main/java/org/hypertrace/alerting/config/service/EventConditionConfigServiceImpl.java +++ b/alerting-config-service-impl/src/main/java/org/hypertrace/alerting/config/service/EventConditionConfigServiceImpl.java @@ -4,6 +4,7 @@ import io.grpc.Status; import io.grpc.stub.StreamObserver; import java.util.UUID; +import java.util.stream.Collectors; import lombok.extern.slf4j.Slf4j; import org.hypertrace.alerting.config.service.v1.CreateEventConditionRequest; import org.hypertrace.alerting.config.service.v1.CreateEventConditionResponse; @@ -17,6 +18,7 @@ import org.hypertrace.alerting.config.service.v1.NewEventCondition; import org.hypertrace.alerting.config.service.v1.UpdateEventConditionRequest; import org.hypertrace.alerting.config.service.v1.UpdateEventConditionResponse; +import org.hypertrace.config.objectstore.ContextualConfigObject; import org.hypertrace.config.service.change.event.api.ConfigChangeEventGenerator; import org.hypertrace.core.grpcutils.context.RequestContext; @@ -50,7 +52,8 @@ public void createEventCondition( builder.setId(UUID.randomUUID().toString()); responseObserver.onNext( CreateEventConditionResponse.newBuilder() - .setEventCondition(eventConditionStore.upsertObject(requestContext, builder.build())) + .setEventCondition( + eventConditionStore.upsertObject(requestContext, builder.build()).getData()) .build()); responseObserver.onCompleted(); } catch (Exception e) { @@ -69,7 +72,9 @@ public void updateEventCondition( responseObserver.onNext( UpdateEventConditionResponse.newBuilder() .setEventCondition( - eventConditionStore.upsertObject(requestContext, request.getEventCondition())) + eventConditionStore + .upsertObject(requestContext, request.getEventCondition()) + .getData()) .build()); responseObserver.onCompleted(); } catch (Exception e) { @@ -87,7 +92,10 @@ public void getAllEventConditions( requestValidator.validateGetAllEventConditionsRequest(requestContext, request); responseObserver.onNext( GetAllEventConditionsResponse.newBuilder() - .addAllEventCondition(eventConditionStore.getAllObjects(requestContext)) + .addAllEventCondition( + eventConditionStore.getAllObjects(requestContext).stream() + .map(ContextualConfigObject::getData) + .collect(Collectors.toUnmodifiableList())) .build()); responseObserver.onCompleted(); } catch (Exception e) { diff --git a/alerting-config-service-impl/src/main/java/org/hypertrace/alerting/config/service/EventConditionStore.java b/alerting-config-service-impl/src/main/java/org/hypertrace/alerting/config/service/EventConditionStore.java index b28fbc58..5c173361 100644 --- a/alerting-config-service-impl/src/main/java/org/hypertrace/alerting/config/service/EventConditionStore.java +++ b/alerting-config-service-impl/src/main/java/org/hypertrace/alerting/config/service/EventConditionStore.java @@ -32,7 +32,7 @@ public EventConditionStore( } @Override - protected Optional buildObjectFromValue(Value value) { + protected Optional buildDataFromValue(Value value) { EventCondition.Builder builder = EventCondition.newBuilder(); try { ConfigProtoConverter.mergeFromValue(value, builder); @@ -45,12 +45,12 @@ protected Optional buildObjectFromValue(Value value) { @SneakyThrows @Override - protected Value buildValueFromObject(EventCondition object) { + protected Value buildValueFromData(EventCondition object) { return ConfigProtoConverter.convertToValue(object); } @Override - protected String getContextFromObject(EventCondition object) { + protected String getContextFromData(EventCondition object) { return object.getId(); } } diff --git a/label-application-rule-config-service-impl/src/main/java/org/hypertrace/label/application/rule/config/service/LabelApplicationRuleConfigServiceImpl.java b/label-application-rule-config-service-impl/src/main/java/org/hypertrace/label/application/rule/config/service/LabelApplicationRuleConfigServiceImpl.java index e595b062..3c06b3cf 100644 --- a/label-application-rule-config-service-impl/src/main/java/org/hypertrace/label/application/rule/config/service/LabelApplicationRuleConfigServiceImpl.java +++ b/label-application-rule-config-service-impl/src/main/java/org/hypertrace/label/application/rule/config/service/LabelApplicationRuleConfigServiceImpl.java @@ -5,6 +5,8 @@ import io.grpc.stub.StreamObserver; import java.util.List; import java.util.UUID; +import java.util.stream.Collectors; +import org.hypertrace.config.objectstore.ConfigObject; import org.hypertrace.config.objectstore.IdentifiedObjectStore; import org.hypertrace.config.service.change.event.api.ConfigChangeEventGenerator; import org.hypertrace.config.service.v1.ConfigServiceGrpc; @@ -51,7 +53,9 @@ public void createLabelApplicationRule( .setData(request.getData()) .build(); LabelApplicationRule createdLabelApplicationRule = - this.labelApplicationRuleStore.upsertObject(requestContext, labelApplicationRule); + this.labelApplicationRuleStore + .upsertObject(requestContext, labelApplicationRule) + .getData(); responseObserver.onNext( CreateLabelApplicationRuleResponse.newBuilder() .setLabelApplicationRule(createdLabelApplicationRule) @@ -70,7 +74,9 @@ public void getLabelApplicationRules( RequestContext requestContext = RequestContext.CURRENT.get(); this.requestValidator.validateOrThrow(requestContext, request); List labelApplicationRules = - this.labelApplicationRuleStore.getAllObjects(requestContext); + this.labelApplicationRuleStore.getAllObjects(requestContext).stream() + .map(ConfigObject::getData) + .collect(Collectors.toUnmodifiableList()); responseObserver.onNext( GetLabelApplicationRulesResponse.newBuilder() .addAllLabelApplicationRules(labelApplicationRules) @@ -90,12 +96,14 @@ public void updateLabelApplicationRule( this.requestValidator.validateOrThrow(requestContext, request); LabelApplicationRule existingRule = this.labelApplicationRuleStore - .getObject(requestContext, request.getId()) + .getData(requestContext, request.getId()) .orElseThrow(Status.NOT_FOUND::asRuntimeException); LabelApplicationRule updateLabelApplicationRule = existingRule.toBuilder().setData(request.getData()).build(); LabelApplicationRule upsertedLabelApplicationRule = - this.labelApplicationRuleStore.upsertObject(requestContext, updateLabelApplicationRule); + this.labelApplicationRuleStore + .upsertObject(requestContext, updateLabelApplicationRule) + .getData(); responseObserver.onNext( UpdateLabelApplicationRuleResponse.newBuilder() .setLabelApplicationRule(upsertedLabelApplicationRule) diff --git a/label-application-rule-config-service-impl/src/main/java/org/hypertrace/label/application/rule/config/service/LabelApplicationRuleStore.java b/label-application-rule-config-service-impl/src/main/java/org/hypertrace/label/application/rule/config/service/LabelApplicationRuleStore.java index 7cb8e0d5..7b787c9a 100644 --- a/label-application-rule-config-service-impl/src/main/java/org/hypertrace/label/application/rule/config/service/LabelApplicationRuleStore.java +++ b/label-application-rule-config-service-impl/src/main/java/org/hypertrace/label/application/rule/config/service/LabelApplicationRuleStore.java @@ -25,7 +25,7 @@ public class LabelApplicationRuleStore extends IdentifiedObjectStore buildObjectFromValue(Value value) { + protected Optional buildDataFromValue(Value value) { try { LabelApplicationRule.Builder builder = LabelApplicationRule.newBuilder(); ConfigProtoConverter.mergeFromValue(value, builder); @@ -37,12 +37,12 @@ protected Optional buildObjectFromValue(Value value) { @SneakyThrows @Override - protected Value buildValueFromObject(LabelApplicationRule object) { + protected Value buildValueFromData(LabelApplicationRule object) { return ConfigProtoConverter.convertToValue(object); } @Override - protected String getContextFromObject(LabelApplicationRule object) { + protected String getContextFromData(LabelApplicationRule object) { return object.getId(); } } diff --git a/labels-config-service-impl/src/main/java/org/hypertrace/label/config/service/LabelStore.java b/labels-config-service-impl/src/main/java/org/hypertrace/label/config/service/LabelStore.java index 02e3c2ec..698fe9c6 100644 --- a/labels-config-service-impl/src/main/java/org/hypertrace/label/config/service/LabelStore.java +++ b/labels-config-service-impl/src/main/java/org/hypertrace/label/config/service/LabelStore.java @@ -24,7 +24,7 @@ protected LabelStore( } @Override - protected Optional