chore: Update data-model #228
Conversation
| shouldRebuildTraceEventsGraph | ||
| ? StructuredTraceGraph.reCreateTraceEventsGraph(trace) | ||
| : StructuredTraceGraph.reCreateTraceEntitiesGraph(trace); | ||
| StructuredTraceGraph graph = cachedGraphThreadLocal.get(); |
There was a problem hiding this comment.
Is there a chance this can be null?
To be safe should we just create a new StructuredTraceGraph if null?
There was a problem hiding this comment.
Although that case shouldn't arise, but added a check for the cachedGraph in the first check
| StructuredTraceGraph graph = StructuredTraceGraph.createGraph(trace); | ||
| StructuredTraceGraph graph = new StructuredTraceGraph(trace); | ||
| LOG.debug( | ||
| "Time taken in building StructuredTraceGraph, duration_millis:{} for tenantId:{}", |
There was a problem hiding this comment.
not related to this PR, but wrap the below debug statement inside a LOG.isDebugEnabled() to avoid the computation of Duration.between(start, Instant.now()).toMillis()
| } else { | ||
| graph.reCreateTraceEntitiesGraph(trace); | ||
| } | ||
| LOG.debug( |
There was a problem hiding this comment.
Same as above.
wrap the below debug statement inside a LOG.isDebugEnabled()
Codecov Report
@@ Coverage Diff @@
## main #228 +/- ##
=========================================
Coverage 80.50% 80.50%
Complexity 1126 1126
=========================================
Files 101 101
Lines 4349 4349
Branches 400 400
=========================================
Hits 3501 3501
Misses 659 659
Partials 189 189
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| } else { | ||
| cachedGraph.reCreateTraceEntitiesGraph(trace); | ||
| } | ||
| if (LOG.isDebugEnabled()) { |
There was a problem hiding this comment.
should this log be inside the if condition ? or may be fix the log statement
There was a problem hiding this comment.
Didn't get your point, what changes are you suggesting in the log statement?
There was a problem hiding this comment.
it says building events graph but it could be either events or entities graph
No description provided.