Skip to content

Conversation

@aaron-steinfeld
Copy link
Contributor

@aaron-steinfeld aaron-steinfeld commented Jul 21, 2021

Description

Updating entity libs for entity caching client concurrency fix.

Source hypertrace/entity-service#112 and hypertrace/entity-service#114

@aaron-steinfeld aaron-steinfeld requested a review from a team July 21, 2021 13:00
findingrish
findingrish previously approved these changes Jul 21, 2021
Copy link
Contributor

@findingrish findingrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

failing build

@findingrish findingrish self-requested a review July 21, 2021 14:02
@aaron-steinfeld
Copy link
Contributor Author

failing build

ugh sorry, danger of the MBP keyboard!

@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #229 (743aba0) into main (0c1c4e0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #229   +/-   ##
=========================================
  Coverage     80.50%   80.50%           
  Complexity     1126     1126           
=========================================
  Files           101      101           
  Lines          4349     4349           
  Branches        400      400           
=========================================
  Hits           3501     3501           
  Misses          659      659           
  Partials        189      189           
Flag Coverage Δ
unit 80.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c1c4e0...743aba0. Read the comment docs.

@github-actions

This comment has been minimized.

@aaron-steinfeld aaron-steinfeld merged commit f558c68 into main Jul 21, 2021
@aaron-steinfeld aaron-steinfeld deleted the use-new-entity-cache branch July 21, 2021 16:35
@github-actions
Copy link

Unit Test Results

  69 files  ±0    69 suites  ±0   56s ⏱️ +9s
359 tests ±0  359 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit f558c68. ± Comparison against base commit 0c1c4e0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants