Skip to content

reduce excessive logging in case of dropped spans #245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 4, 2021
Merged

reduce excessive logging in case of dropped spans #245

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f2cd42f
log dropped spans in rate limited manner
satish-mittal Jul 29, 2021
8e9d652
log reason for dropping span
satish-mittal Jul 29, 2021
8bbc2b7
Merge branch 'main' into log_ratelimit_when_span_dropped
satish-mittal Aug 4, 2021
60adf83
reduce excessive logging of dropped spans
satish-mittal Aug 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...r/span-normalizer/src/main/java/org/hypertrace/core/spannormalizer/jaeger/SpanFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
@SuppressWarnings("UnstableApiUsage")
public class SpanFilter {
private static final Logger LOG = LoggerFactory.getLogger(SpanFilter.class);
private static final RateLimiter DROPPED_SPANS_RATE_LIMITER = RateLimiter.create(1.0);
private static final RateLimiter DROPPED_SPANS_RATE_LIMITER = RateLimiter.create(0.01);
private static final String SPAN_KIND_TAG =
RawSpanConstants.getValue(SpanAttribute.SPAN_ATTRIBUTE_SPAN_KIND);
private static final String SPAN_KIND_CLIENT = "client";
Expand Down