refactor: change entity write to improve throughput #248
Conversation
Codecov Report
@@ Coverage Diff @@
## main #248 +/- ##
=========================================
Coverage 80.30% 80.30%
+ Complexity 1150 1145 -5
=========================================
Files 101 101
Lines 4447 4442 -5
Branches 416 417 +1
=========================================
- Hits 3571 3567 -4
+ Misses 680 679 -1
Partials 196 196
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
| Channel getConfigServiceChannel(); | ||
|
|
||
| TraceEntityReader<StructuredTrace, Event> getEntityReader(); | ||
| TraceEntityAccessor getTraceEntityAccessor(); |
There was a problem hiding this comment.
Since this is both reading and writing, tried my hand at a rename... happy to take suggestions though!
| import org.hypertrace.core.datamodel.Event; | ||
| import org.hypertrace.core.datamodel.StructuredTrace; | ||
|
|
||
| public interface TraceEntityAccessor { |
There was a problem hiding this comment.
the previously parameterized version was always used with the same parameters, so removed them.
| @@ -1,4 +1,4 @@ | |||
| package org.hypertrace.trace.reader.entities; | |||
| package org.hypertrace.trace.accessor.entities; | |||
There was a problem hiding this comment.
I moved this package, but I left the attribute reader and the project named trace-reader to keep the diff from getting too crazy. I'll rename those packages/classes and the project itself later (probably when we start supporting write for attributes, unless there's a desire to do it sooner).
Description
Motivation for this change is discussed in hypertrace/entity-service#123
Testing
Verified E2E, updated UTs
Checklist: